Skip to content

Don't allow redirects when contacting the CTS from NERSC #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrCreosote merged 1 commit into from
Aug 28, 2026
Merged

Don't allow redirects when contacting the CTS from NERSC #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cdmtaskservice/nersc/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ def _error_wrapper(func: Callable, args: list[str], result_file_path: str, callb
callback_file = cf.parent / f"{cf.stem}.callback_error{cf.suffix}"
try:
# may want some retries here, halting on incorrect job state messages
ret = requests.get(callback_url)
# Redirects are disallowed since the callback target is dynamically supplied and
# a redirect could be used to route the request to an arbitrary, untrusted host.
ret = requests.get(callback_url, allow_redirects=False)
if ret.status_code < 200 or ret.status_code > 299:
failed = True
# log callback errors for debugging purposes, service will never see this
Expand All @@ -118,6 +120,7 @@ def _error_wrapper(func: Callable, args: list[str], result_file_path: str, callb
"result": "fail",
"callback_text": ret.text,
"callback_code": ret.status_code,
"callback_redirect_location": ret.headers.get("Location"),
"cts_env": cts_env
}
json.dump(j, f, indent=4)
Expand Down