Skip to content

Probe: Stainless preview vs csharp-free base (throwaway)#659

Closed
ls-bolt[bot] wants to merge 1 commit into
07-06-pan-embed-url-fetch-on-demand-docsfrom
07-07-stainless-csharp-union-probe
Closed

Probe: Stainless preview vs csharp-free base (throwaway)#659
ls-bolt[bot] wants to merge 1 commit into
07-06-pan-embed-url-fetch-on-demand-docsfrom
07-07-stainless-csharp-union-probe

Conversation

@ls-bolt

@ls-bolt ls-bolt Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Claim this PR — take ownership under your GitHub account

Throwaway probe for the csharp preview investigation on #657 — do not review or merge.

Question: does builds.compare union the target set across base and head? On #657, the head config verifiably lacked the csharp target yet the server still built csharp — the suspected reason is that the base build (from the merge base = main, which still has csharp) forces csharp into the comparison.

Setup: this PR is based on 07-06-pan-embed-url-fetch-on-demand-docs (csharp-free config on both sides) and carries a doc-comment-only codegen delta (GtqAccountInfoBase.bankAccountType description) — the exact class of change proven to fail preview against a main base.

Read-out:

Will report the result on #657 and close this PR.

🤖 thundering-graviton(#2) | Feedback

@benwgold @claude
Probe: does a codegen-delta PR based on a csharp-free branch pass pre…
52b1b7d 
…view?

Doc-comment-only delta (proven to fail preview when based on main).
This PR's merge base lacks the csharp target, so if the Stainless
preview check goes green here, the compare API unions targets across
base and head — meaning the csharp removal fixes the check once it
reaches main. Throwaway probe; will be closed either way.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ls-bolt ls-bolt Bot added the bolt label Jul 7, 2026
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Jul 7, 2026 1:39am
grid-wallet-demo Ignored Ignored Jul 7, 2026 1:39am

Request Review

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

csharp

chore(internal): regenerate SDK with no functional changes

go

docs(types): clarify bank account type description in GTQ external account

kotlin

docs(api): update bankAccountType descriptions in account info models

openapi

docs(api): update bankAccountType field description

php

docs(types): update BankAccountType documentation

python

docs(types): update bank_account_type description in gtq_external_account_create_info

ruby

chore(internal): regenerate SDK with no functional changes

typescript

docs(types): clarify bankAccountType description in GTQ account types

Edit this comment to update them. They will appear in their respective SDK's changelogs.

✅ grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

✅ grid-ruby studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅ → build ✅ → lint ✅ → test ✅

✅ grid-go studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅ → build ✅ → lint ❗ → test ❗

go get github.com/stainless-sdks/grid-go@9f1e30be260d746d26fc9a054066f833563a5515
✅ grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️ → build ✅ → lint ✅ → test ❗

✅ grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅ → build ✅ → lint ❗ → test ✅

npm install https://pkg.stainless.com/s/grid-typescript/9da083062cb253fae84da289cf1fcb1ac74bb461/dist.tar.gz
✅ grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅ → build ✅ → lint ❗ → test ❗

pip install https://pkg.stainless.com/s/grid-python/92f8c0eb2a5a810e854d3328d57e9a73da817b96/grid-0.0.1-py3-none-any.whl
✅ grid-csharp studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️ → build ❗ → lint ✅ → test ❗

✅ grid-php studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅ → lint ✅ → test ✅

✅ grid-cli studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️ → build ⏭️ (prev: build ❗) → lint ⏭️ (prev: lint ❗) → test ❗

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-07 01:44:24 UTC

@ls-bolt

ls-bolt Bot commented Jul 7, 2026

Copy link
Copy Markdown
Author

Probe complete: preview PASSED (see #657 for the full verdict). csharp still built and its build CI still failed, but base failed identically → 'did not represent a regression' → green. Closing.

@ls-bolt ls-bolt Bot closed this Jul 7, 2026
@ls-bolt ls-bolt Bot deleted the 07-07-stainless-csharp-union-probe branch July 7, 2026 01:46
This was referenced Jul 7, 2026
Merged
Closed
@benwgold benwgold mentioned this pull request Jul 8, 2026
Merged
benwgold added a commit that referenced this pull request Jul 8, 2026
@benwgold @claude
Remove the broken Stainless csharp target so spec PRs stop failing CI (…
f7b7ab9 
…#671)

## Summary

Removes the csharp target from `.stainless/stainless.yml` so the `Build
SDKs for pull request / preview` check stops failing on every
spec-changing PR.

**Why every spec PR is red**: Stainless's csharp build CI is broken
upstream for ANY freshly generated code (content-independent, proven by
bisect on #650, breakage window ~Jul 3). The preview check gates on a
per-language head-vs-base regression, and with csharp in main's config
the base build resolves to a cached pre-breakage csharp *success* — so
every fresh head failure counts as a regression → red.

**Why this fixes it**: with csharp out of the config on main, base
builds have no cached csharp success to regress from — matching outcomes
on base and head → "not a regression" → green. Proven end-to-end by
probe #659: the exact previously-failing change class (doc-comment-only
codegen delta) ran against a csharp-free base and `preview` **passed**.
Full mechanics: [investigation
writeup](#657 (comment)).

**No shipping impact**: the csharp target is unpublished
(`production_repo: null`, `publish.nuget: false`). Re-add the block when
Stainless fixes their csharp build CI upstream.

## Sequencing (for #657 and other open spec PRs)

1. Merge this PR — **its own `preview` will be red** (its base is
current main); merge through it (precedent: #633, #637).
2. Merge/rebase main into open spec PRs (e.g. #657) — their next
`preview` run goes green.

## Verification

- `make lint` passes; the file matches the exact removal previously
validated on the #657 branch (commit 069ad9a) and by probe #659.

---
🤖
[thundering-graviton-3](https://zeus.dev.dev.sparkinfra.net/#/arc?id=thundering-graviton)[(#3)](https://zeus.dev.dev.sparkinfra.net/#/instance?id=thundering-graviton-3)
| [Feedback](https://zeus.dev.dev.sparkinfra.net/feedback)

Original PR: #663

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bolt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benwgold