Skip to content

chore(arabic/markazriwayat): park broken source and point to Galaxy Novels - #2530

Open
RibatTRW wants to merge 3 commits into
lnreader:masterfrom
RibatTRW:fm/lnreader-markazriwayat-broken
Open

RibatTRW wants to merge 3 commits into
lnreader:masterfrom
RibatTRW:fm/lnreader-markazriwayat-broken

Conversation

@RibatTRW

@RibatTRW RibatTRW commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Change

Disposition of the fifth source left unverified by #2529. Related to #2522 — deliberately no closing keyword, since this removes rather than repairs: markazriwayat.com serves no novel content on any route. Direct requests hit a Cloudflare challenge, behind which sits only a Hostinger "Coming Soon" placeholder and a theme 404 page. There is nothing left to parse.

  • plugins/arabic/Markazriwayat.ts → plugins/arabic/Markazriwayat.broken.ts, the repo's documented convention for an unavailable source (excluded from production compilation, source retained). The header comment names the successor: the operators' own Coming Soon page announces Galaxy Novels (galaxynovels.com) as their affiliated site, already shipped here as the galaxynovels plugin.
  • Follow-up commit on this branch: the live checker skips parked *.broken.ts sources (workflow target exclusion plus an INCONCLUSIVE short-circuit in scripts/live-check-plugin.js, documented in docs/testing.md), since checking them can only fail by design.
  • Not added to BLACKLIST.json (owner-takedown entries, not downtime). No version bump, per the chore: Source Cleanup #1977 retirement precedent.

Verification

build:compile exits 0 with no *markaz* in output; the manifest reports the source broken and carries zero markazriwayat ids. Lint (2 errors / 10 warnings) and format findings are identical before and after — all pre-existing in untouched files. No live check is possible: the site serves no content, which is the reason for the PR.

Left untouched deliberately: generated keys.json / issue-template keys (rewritten by workflow after release) and the icon asset, matching other parked plugins. AI-authored change, no human review; the successor detail was confirmed via a second egress route.

…ovels

markazriwayat.com serves no novel content on any route: direct requests get a
Cloudflare challenge and the origin behind it only returns a "Coming Soon"
placeholder with a theme 404 on every deeper path. There is nothing left to
parse, so no code change can repair this source.

Rename the plugin to the repository's `*.broken.ts` convention, which excludes
it from production compilation and reports it as broken in the manifest build,
while retaining the source. No BLACKLIST.json entry: that file holds owner
takedowns, not downtime.

The plugin's header now points readers at Galaxy Novels (galaxynovels.com),
which the same operators announce on their Coming Soon page as their affiliated
successor site and which already ships as the `galaxynovels` plugin.

AI-authored change (pi coding agent). Not human-reviewed.
A '*.broken.ts' rename deliberately parks an unrecoverable source outside
production compilation, but the live-check workflow still targeted
'plugins/**/*.ts' including the parked file, so the parked source failed
the PR by design (ref lnreader#2522). Exclude
'plugins/**/*.broken.ts' from the workflow's changed-files trigger (same
as the existing multisrc-generated exclusion) and short-circuit
scripts/live-check-plugin.js to INCONCLUSIVE for '*.broken.ts' paths so
manual and workflow_dispatch runs skip them too. Healthy plugins are
unaffected and still run the full check.

AI-authored change (pi coding agent). Not human-reviewed.
@RibatTRW

Copy link
Copy Markdown
Contributor Author

Pushed d35f06a for this head: the live check now skips a parked *.broken.ts source (INCONCLUSIVE) instead of failing it on its dead site, while healthy plugins are still fully checked. Local lint, format and compile pass; the renamed source is excluded from the build. The check run for this head is waiting on approval — could you approve it so the check can report?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant