fix(android): address Google Play automated review recommendations - #85
Merged
Merged
Conversation
…x to 1.16.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ket media3 keep with targeted ExoPlayerImpl keep
There was a problem hiding this comment.
Pull request overview
Updates Android configuration to align with Google Play automated review recommendations, focusing on Android 15 edge-to-edge behavior, dependency hygiene around deprecated system bar APIs, and improved R8 optimization while preserving required JNI/Skip bridge entry points.
Changes:
- Bump
androidx.core:core-ktxto1.16.0inMaxi80ServicesAndroid Gradle deps (viaskip.yml). - Add an Android 15+ (
values-v35) theme override to explicitly opt into edge-to-edge enforcement. - Tighten
proguard-rules.proby scoping-keeppackagenamesand narrowing the Media3 keep rule toExoPlayerImpl.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Maxi80Services/Skip/skip.yml | Updates Android dependency version for androidx.core:core-ktx. |
| Android/app/src/main/res/values-v35/themes.xml | Adds API 35 theme override to explicitly opt into edge-to-edge enforcement. |
| Android/app/proguard-rules.pro | Refines keep/package-name rules to improve R8 shrinking/obfuscation while preserving required bridge/JNI behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
values-v35/themes.xmlto explicitly opt into edge-to-edge display on Android 15+, in addition to the existingenableEdgeToEdge()call inMainActivityandroidx.core:core-ktxfrom1.15.0→1.16.0inMaxi80Services/Skip/skip.ymlto pull in a newerandroidx.activitythat removes the deprecatedsetStatusBarColor/setNavigationBarColorshims Google flagged-keep class androidx.media3.** { *; }with a targeted-keep class androidx.media3.exoplayer.ExoPlayerImpl { *; }inproguard-rules.pro; scoped-keeppackagenamesfrom**to onlymaxi80.**/skip.**/tools.skip.**— this unblocks R8 from optimizing ~2 MB of media3 bytecode and flattening third-party package namesTest plan
swift test --no-parallel— 251 tests pass (2 pre-existing failures onmainunrelated to this change)cd Android && ./gradlew assembleRelease— BUILD SUCCESSFUL (verified locally, mapping.txt 849k lines confirming aggressive R8 obfuscation)Notes
The deprecated API calls Google flagged (
Window.setStatusBarColor,Window.setNavigationBarColor,LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES) trace to library internals (androidx.activity.z.b/x.a), not app code. Bumpingcore-ktxupdates the transitiveandroidx.activitydependency that contains those shims.These are Google Play recommendations, not review blockers — the 5.0.7 release currently in review will proceed regardless.
🤖 Generated with Claude Code