-
Notifications
You must be signed in to change notification settings - Fork 0
fix(android): address Google Play automated review recommendations #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,20 @@ | ||
| -keeppackagenames ** | ||
| # Skip framework packages must be kept verbatim — JNI looks them up by name. | ||
| -keeppackagenames maxi80.** | ||
| -keeppackagenames skip.** | ||
| -keeppackagenames tools.skip.** | ||
| -keep class skip.** { *; } | ||
| -keep class tools.skip.** { *; } | ||
| -keep class kotlin.jvm.functions.** {*;} | ||
| -keep class kotlin.jvm.functions.** { *; } | ||
| -keep class com.sun.jna.** { *; } | ||
| -dontwarn java.awt.** | ||
| -keep class * implements com.sun.jna.** { *; } | ||
| -keep class * implements skip.bridge.** { *; } | ||
| -keep class **._ModuleBundleAccessor_* { *; } | ||
| -keep class maxi80.module.** { *; } | ||
| # Transpiled Maxi80Services classes are reached only via JNI-by-name from the native | ||
| # Swift bridge (e.g. PlatformEnvironment), so R8 can't see the reference and would | ||
| # strip/rename them — causing ClassNotFoundException at launch in minified builds. | ||
| # Transpiled Maxi80Services classes are reached only via JNI-by-name from the native Swift bridge. | ||
| -keep class maxi80.services.** { *; } | ||
|
|
||
| # Media3 (ExoPlayer) surface used by the now-playing writeback. The phone playback path drives | ||
| # the notification metadata through the Skip JNI-by-name bridge: | ||
| # AndroidNowPlayingController.platformUpdateNowPlaying → player.getCurrentMediaItem / | ||
| # getCurrentMediaItemIndex / replaceMediaItem, rendered by DefaultMediaNotificationProvider from | ||
| # MediaItem.getMediaMetadata(). R8 can't see those by-name references in a minified release build | ||
| # and could strip/rename them, leaving the initial metadata stuck — matching issue #13. | ||
| # | ||
| # Deliberately broad (whole `androidx.media3.**`, not just `.common.**`) rather than relying on | ||
| # Media3's own consumer ProGuard rules: the by-name bridge reflects on the CONCRETE runtime type | ||
| # returned by SharedAudioPlayer.shared() — an ExoPlayer whose implementation lives in | ||
| # `androidx.media3.exoplayer` (ExoPlayerImpl), not `androidx.media3.common`. Scoping the keep to | ||
| # `.common.**` would leave the actually-reflected methods (getCurrentMediaItem / replaceMediaItem / | ||
| # getCurrentMediaItemIndex) on the impl class renamable, reintroducing the R8-strips-JNI-bridged- | ||
| # class crash. The keep is chosen over Media3's consumer rules for that reason. | ||
| -keep class androidx.media3.** { *; } | ||
| # ExoPlayerImpl is the concrete class the JNI bridge receives from SharedAudioPlayer.shared(). | ||
| # Media3's own consumer ProGuard rules keep the rest of the public API. | ||
| -keep class androidx.media3.exoplayer.ExoPlayerImpl { *; } | ||
| -dontwarn androidx.media3.** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <!-- Android 15 (API 35) enforces edge-to-edge by default. We call enableEdgeToEdge() | ||
| in MainActivity.onCreate() and set transparent bar styles via SyncSystemBarsWithTheme(), | ||
| so we opt in explicitly here rather than relying on the platform default. --> | ||
| <style name="Theme.Maxi80" parent="Theme.AppCompat.DayNight.NoActionBar"> | ||
| <item name="android:windowBackground">@android:color/black</item> | ||
| <item name="android:windowSplashScreenBackground">@android:color/black</item> | ||
| <item name="android:windowOptOutEdgeToEdgeEnforcement">false</item> | ||
| </style> | ||
| </resources> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.