Add missing defaults to tri, tril, triu, gather_mm signatures - #4492
Open
rishabhsai wants to merge 1 commit into
Open
rishabhsai wants to merge 1 commit into
rishabhsai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signatures for
tri,tril,triu, andgather_mmomit defaults that their Python bindings already provide. The generated stubs therefore mark these arguments as required, causing Pyright to reject valid calls such asmx.tri(3)andmx.gather_mm(x, x).This updates the four
nb::sigstrings inpython/src/ops.cppto match the existing bindings and docstrings:tri: declarem: int | None = Noneandk: int = 0.trilandtriu: declarek: int = 0.gather_mm: declare both index arguments asarray | None = None.There is no runtime behavior change.
Validation used a CPU-only source build. The regenerated stubs contain the corrected signatures, and Pyright reports zero errors on six example calls that previously produced six missing-argument errors. Those calls execute successfully both before and after the change. The existing
tri,tril, andtriutests pass, as does the clang-format check.