Skip to content

Add missing defaults to tri, tril, triu, gather_mm signatures #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishabhsai wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Add missing defaults to tri, tril, triu, gather_mm signatures #4492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/src/ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2106,7 +2106,7 @@ void init_ops(nb::module_& m) {
nb::kw_only(),
"stream"_a = nb::none(),
nb::sig(
"def tri(n: int, m: int, k: int, dtype: Dtype | None = None, *, stream: StreamOrDevice = None) -> array"),
"def tri(n: int, m: int | None = None, k: int = 0, dtype: Dtype | None = None, *, stream: StreamOrDevice = None) -> array"),
R"pbdoc(
An array with ones at and below the given diagonal and zeros elsewhere.

Expand All @@ -2128,7 +2128,7 @@ void init_ops(nb::module_& m) {
nb::kw_only(),
"stream"_a = nb::none(),
nb::sig(
"def tril(x: array, k: int, *, stream: StreamOrDevice = None) -> array"),
"def tril(x: array, k: int = 0, *, stream: StreamOrDevice = None) -> array"),
R"pbdoc(
Zeros the array above the given diagonal.

Expand All @@ -2148,7 +2148,7 @@ void init_ops(nb::module_& m) {
nb::kw_only(),
"stream"_a = nb::none(),
nb::sig(
"def triu(x: array, k: int, *, stream: StreamOrDevice = None) -> array"),
"def triu(x: array, k: int = 0, *, stream: StreamOrDevice = None) -> array"),
R"pbdoc(
Zeros the array below the given diagonal.

Expand Down Expand Up @@ -5153,7 +5153,7 @@ void init_ops(nb::module_& m) {
"sorted_indices"_a = false,
"stream"_a = nb::none(),
nb::sig(
"def gather_mm(a: array, b: array, /, lhs_indices: array, rhs_indices: array, *, sorted_indices: bool = False, stream: StreamOrDevice = None) -> array"),
"def gather_mm(a: array, b: array, /, lhs_indices: array | None = None, rhs_indices: array | None = None, *, sorted_indices: bool = False, stream: StreamOrDevice = None) -> array"),
R"pbdoc(
Matrix multiplication with matrix-level gather.

Expand Down