feat(cli): K2 merged download smoke with selective install --download#190
Open
oldrepublicwizard wants to merge 1 commit into
Open
feat(cli): K2 merged download smoke with selective install --download#190oldrepublicwizard wants to merge 1 commit into
oldrepublicwizard wants to merge 1 commit into
Conversation
install --download now fetches only IsSelected components so --select mod:NAME works for single-mod network smoke. Adds LongRunning test, agent script, and docs.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install --downloadnow fetches onlyIsSelectedcomponents, so--select mod:NAMEenables single-mod network smoke without downloading the full 145-mod list.K2FullGuideDownloadTests(LongRunning): merge neocities fixture + goldenKOTOR2_Full.toml, theninstall --download --select mod:Silent Sion Restoration.scripts/agents/k2_ingested_merge_download_smoke.shand documents the behavior incli-selection-semantics.md.Test plan
dotnet test --filter FullyQualifiedName~K2FullGuideFixture_MergedSilentSion_DownloadsViaInstallSelect_LongRunning(network; ~2 min)dotnet test --filter FullyQualifiedName~K2FullGuideMergeTests./scripts/agents/k2_ingested_merge_download_smoke.sh --download-mod "Silent Sion Restoration"Stacks on #189.