fix(auth): bind OAuth state to the initiating browser - #31
Closed
albertovincenzi wants to merge 1 commit into
Closed
fix(auth): bind OAuth state to the initiating browser#31albertovincenzi wants to merge 1 commit into
albertovincenzi wants to merge 1 commit into
Conversation
This was referenced Sep 4, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OAuth
stateJWT was signed, but it was not tied to the browser that initiated the login. Signing prevents mutation; it does not prevent an attacker from initiating and completing their own Google login, then sending that valid callback URL to a victim. Loading it would replace the victim’s Gate session with the attacker’s identity (login CSRF / session swapping).Fix
Secureon HTTPS deploymentsNotes for Alice
This PR is intentionally stacked on #15 because both touch the OAuth state flow; review/merge #15 first. SameSite=Lax still allows Google’s top-level GET redirect, while the host-only callback-scoped cookie prevents a callback prepared in another browser from being accepted. No provider configuration changes are required.
Verification
cargo test --workspacecargo clippy --workspace --all-targets -- -D warnings