refactor: move event primitives into DOM - #282
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
jderochervlk
changed the base branch from
main
to
codex/event-api-split-without-rescript-13
June 26, 2026 17:33
jderochervlk
changed the base branch from
codex/event-api-split-without-rescript-13
to
main
June 26, 2026 17:34
jderochervlk
commented
Jul 6, 2026
jderochervlk
commented
Jul 6, 2026
jderochervlk
commented
Jul 6, 2026
| */ | ||
| @editor.completeFrom(BaseCSSFontLoading.FontFaceSet) | ||
| type rec fontFaceSet = private { | ||
| ...BaseEvent.eventTarget, |
Collaborator
Author
There was a problem hiding this comment.
This was just spreading an empty object and creating a circular dependency.
jderochervlk
commented
Jul 6, 2026
Comment on lines
+30
to
+32
| @editor.completeFrom(Window) | ||
| type window = private {} | ||
| external window: window = "window" |
Collaborator
Author
There was a problem hiding this comment.
Adding this here allows accessing the window using DOM.window instead of Window.current.
jderochervlk
commented
Jul 6, 2026
jderochervlk
marked this pull request as ready for review
July 6, 2026 19:23
This was referenced Jul 9, 2026
jderochervlk
force-pushed
the
codex/event-api-split
branch
from
August 3, 2026 18:06
9b0b39b to
8f370a1
Compare
This was referenced Aug 3, 2026
fhammerschmidt
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack context
Part 2 of 16 in the first Option 5 stack: flat interface ownership and compatibility cleanup.
Review this PR as the incremental diff against #298.
Summary
DOMBaseEventandEventTypeswrapper modules retained by refactor: separate EventType feature #298DOMevent types directlyDomGlobalTemporary state
Review focus
DOMare genuinely foundationalVerification
npm run buildnpm testnpm run format:check