Skip to content

refactor: expose browser window from DOM - #299

Closed
jderochervlk wants to merge 1 commit into
codex/event-api-splitfrom
codex/dom-window-access
Closed

refactor: expose browser window from DOM#299
jderochervlk wants to merge 1 commit into
codex/event-api-splitfrom
codex/dom-window-access

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Summary

  • expose the browser global as WebAPI.DOM.window
  • migrate examples and API documentation from WebAPI.Window.current to the shared DOM value
  • cover event, location, fetch, and visual-viewport usage through DOM.window
  • retain Window.current for source compatibility

Temporary state

  • Window.t is still backed by the broad DomTypes.window definition in this layer; refactor: remove DOM compatibility types #310 moves the remaining window types out of DomTypes and deletes that compatibility module
  • DOM.window itself is the intended foundational entry point, not temporary scaffolding
  • physical folder ownership and the partial feature map are completed in the follow-up Option 5 stack

Review focus

  • the canonical browser-global entry point and documentation migration
  • preserving the existing Window.current API while consumers move to DOM.window

Verification

  • npm run build
  • npm test
  • npm run format:check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca15e44bb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md

Copy link
Copy Markdown
Collaborator Author

This layer has been folded into #282 so DOM.window lands with the foundational DOM changes. The remaining stack now bases #286 directly on #282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant