Point the start-image guidance at options.inputSrc and the models that take one - #133
Merged
Merged
Conversation
|
🎉 This PR is included in version 1.18.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three places in the docs point at something that does not work.
The ImageToVideoAsset deprecation notice told people to move to VideoAsset with
promptandinputSrc.inputSrchas never been a root VideoAsset property — it belongs inoptions— and not every video model accepts one. It now namesoptions.inputSrcand a model that takes it.The two VideoAsset descriptions said
optionsincludes a starting image without qualification. Only some models animate a starting image; others generate from the prompt alone.The smoke test paired a text-to-video model with
options.inputSrc. It passes either way, since the generated Zod treatsoptionsas an open object, so it was teaching the wrong thing rather than failing.Descriptions only. No schema shapes change, so generated types and clients are unaffected.
Verify:
pnpm buildregenerates cleanly and all 71 smoke tests pass.Note: merge after the registry change that stops the default video model accepting a starting image, or this documents behaviour that is not live yet.