feat(http): Add connection metrics - #271
Open
bboreham wants to merge 1 commit into
Open
Conversation
Add metrics `net_conntrack_dialer_conn_*_total` for every connection attempted, failed, closed, etc. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add metrics
net_conntrack_dialer_conn_*_totalfor every connection attempted, failed, closed, etc.Commentary
Conntrack metrics have a
dialer_namelabel that can be useful to see connections for different reasons.It would be rather invasive to add this as a parameter to
DefaultTransport, but there is a helperconntrack.DialNameToContextwhich lets you pass the name via context from the point where the dial is triggered.Verification
I have been using this with Loki, which uses
thanos-io/objstorefor blob access.