Skip to content

feat(http): Add connection metrics #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoaoBraveCoding merged 4 commits into from
Aug 28, 2026
+17 −9
Merged

feat(http): Add connection metrics #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2f776e
feat(http): Add connection metrics
bboreham Aug 24, 2026
55a65a6
Default the dialer_name label to "objstore".
bboreham Aug 28, 2026
e591776
Make conntract dependency explicit
bboreham Aug 28, 2026
8b7f3f7
Merge branch 'main' into conntrack-metrics
bboreham Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#155](https://github.com/thanos-io/objstore/pull/155) Add a `Provider` method on `objstore.Client`.
- [#163](https://github.com/thanos-io/objstore/pull/145) Add a `NewBucketFromConfig` constructor method for creating a client from an existing `BucketConfig` object.
- [#266](https://github.com/thanos-io/objstore/pull/266) *: Add `force_attempt_http2` option to `http_config` to re-enable HTTP/2 for the custom transport.

- [#271](https://github.com/thanos-io/objstore/pull/271) Add metrics `net_conntrack_dialer_conn_*_total` for every connection attempted, failed, etc.

### Changed
- [#38](https://github.com/thanos-io/objstore/pull/38) *: Upgrade minio-go version to `v7.0.45`.
Expand Down
22 changes: 15 additions & 7 deletions exthttp/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"net/http"
"time"

conntrack "github.com/mwitkow/go-conntrack"
Comment thread
bboreham marked this conversation as resolved.
"github.com/prometheus/common/model"
)

Expand Down Expand Up @@ -52,14 +53,21 @@ func DefaultTransport(config HTTPConfig) (*http.Transport, error) {
}
tlsConfig.InsecureSkipVerify = config.InsecureSkipVerify

return &http.Transport{
Proxy: http.ProxyFromEnvironment,
DialContext: (&net.Dialer{
Timeout: 30 * time.Second,
KeepAlive: 30 * time.Second,
DualStack: true,
}).DialContext,
dialFn := (&net.Dialer{
Timeout: 30 * time.Second,
KeepAlive: 30 * time.Second,
DualStack: true,
}).DialContext
// conntrack exports metrics for every connection attempted, failed, etc.
dialFn = conntrack.NewDialContextFunc(
conntrack.DialWithDialContextFunc(dialFn),
Comment thread
bboreham marked this conversation as resolved.
// Can be overwritten with conntrack.DialNameToContext.
conntrack.DialWithName("objstore"),
)

return &http.Transport{
Proxy: http.ProxyFromEnvironment,
DialContext: dialFn,
MaxIdleConns: config.MaxIdleConns,
MaxIdleConnsPerHost: config.MaxIdleConnsPerHost,
IdleConnTimeout: time.Duration(config.IdleConnTimeout),
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ require (
github.com/go-kit/log v0.2.1
github.com/huaweicloud/huaweicloud-sdk-go-obs v3.25.4+incompatible
github.com/minio/minio-go/v7 v7.0.95
github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f
github.com/ncw/swift v1.0.53
github.com/opentracing/opentracing-go v1.2.0
github.com/oracle/oci-go-sdk/v65 v65.41.1
Expand Down Expand Up @@ -94,7 +95,6 @@ require (
github.com/minio/md5-simd v1.1.2 // indirect
github.com/mitchellh/mapstructure v1.4.3 // indirect
github.com/mozillazg/go-httpheader v0.2.1 // indirect
github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f // indirect
github.com/philhofer/fwd v1.2.0 // indirect
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
Expand Down
Loading