Skip to content

Do more internal refactoring in reduce-then-scan - #2830

Open
akukanov wants to merge 8 commits into
dev/rts-use-storage-holder-akukanovfrom
dev/rts-internals-refactoring
Open

akukanov wants to merge 8 commits into
dev/rts-use-storage-holder-akukanovfrom
dev/rts-internals-refactoring

Conversation

@akukanov

@akukanov akukanov commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Changes in this PR:

  • parallel_backend_sycl.h - moved blocks of code without modifications for better grouping within the file.
  • utils_ranges_sycl.h - removed unnecessary template parameter in the implementation of __require_access
  • moved block carry routines out of scan submitter (because I will later need a similar routine in both scan and reduce submitters).
  • moved __temp_data_required next to the input generators, which this trait is applied to.
  • changed the scan-through-elements helper stack:
    • lowered communication tag dispatching to the "_impl" routine.
    • made the reduce submitter use "_impl" directly; the respective code path in __scan_through_elements_helper was trivial.
    • moved the functionality of __scan_through_elements_helper into a member function of the scan submitter, and merged more of operator() code into this new routine, including processing of out-of-bound writes and stop positions

The changes reduce the overall amount of code, set a single condition (__temp_data_required) for both reads and writes (instead of a different and seemingly unrelated __has_final_pos for writes), and reduce the API surface of scan-through-elements routines via direct access to data members of scan submitter.

@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch 8 times, most recently from 2c4ecbb to c42601d Compare September 18, 2026 14:39
@akukanov
akukanov changed the base branch from main to dev/storage-refactoring-continued-akukanov September 18, 2026 14:39
@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch 2 times, most recently from d002417 to 4acfac6 Compare September 18, 2026 14:53
@akukanov
akukanov changed the base branch from dev/storage-refactoring-continued-akukanov to main September 18, 2026 14:54
@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch 2 times, most recently from 334a598 to 5c12770 Compare September 18, 2026 15:11
@akukanov
akukanov changed the base branch from main to dev/rts-use-storage-holder-akukanov September 18, 2026 15:11
@akukanov
akukanov added this pull request to stack #2820 September 18, 2026 15:11
@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch 2 times, most recently from 334d946 to e34a4fd Compare September 18, 2026 18:37
@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch from e34a4fd to 2c4f37b Compare September 18, 2026 19:02
@akukanov
akukanov force-pushed the dev/rts-internals-refactoring branch from 2c4f37b to bd47d73 Compare September 18, 2026 20:08
@akukanov akukanov changed the title more internal refactoring in reduce-then-scan Do more internal refactoring in reduce-then-scan Sep 21, 2026
@akukanov
akukanov marked this pull request as ready for review September 21, 2026 13:11
@akukanov akukanov added this to the 2022.15.0 milestone Sep 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant