tests: add expand #t0132 (@base vs property keys) - #686
anatoly-scherbakov wants to merge 4 commits into
Conversation
|
My agent fixed |
pchampin
left a comment
pchampin
left a comment
There was a problem hiding this comment.
My agent fixed LoadDocumentOptions once again after #684,
you should train it to behave!
that commit can be easily removed while rebasing if that PR, or its predecessor, is merged.
Please do make these changes before submitting the PR (like cherrypicking or rebasing locally). This may creates unnecessary friction when we decide to merge that.
Apart from this, the test looks good to me.
7a63bae to
e00f4fc
Compare
|
Now that Specref is up, CI is green again! Perhaps we could merge? cc @niklasl |
niklasl
left a comment
niklasl
left a comment
There was a problem hiding this comment.
Confirming behavior according to spec.
|
Thanks @niklasl! Can you please merge this then? I do not have the permissions. Thank you! |
| </dd> | ||
| </dl> | ||
| </dd> | ||
| <dt id='t0028'> |
There was a problem hiding this comment.
Nitpick to be sure: was this a previous discrepancy which got corrected when the HTML was regenerated?
| </dl> | ||
| </dd> | ||
| <dt id='t0028'> | ||
| Test t0028 use native types flag with non-native values |
There was a problem hiding this comment.
Maybe?
| Test t0028 use native types flag with non-native values | |
| Test t0028 `useNativeTypes` flag with non-native values |
| <dt>Type</dt> | ||
| <dd>jld:PositiveEvaluationTest, jld:FromRDFTest</dd> | ||
| <dt>Purpose</dt> | ||
| <dd>Ensure that useNativeTypes flag being true does not interfere with values that cannot be serialized into a native value.</dd> |
There was a problem hiding this comment.
| <dd>Ensure that useNativeTypes flag being true does not interfere with values that cannot be serialized into a native value.</dd> | |
| <dd>Ensure that `useNativeTypes` flag being true does not interfere with values that cannot be serialized into a native value.</dd> |
This branch has not been deployed
4 participants
Summary
Adds ExpandTest
#t0132: with a context that sets only@base(and@version1.1), an unmapped simple property key likenameis dropped, while a relative@typetoken still resolves against that base (IRI Expansion).Files
tests/expand/0132-in.jsonld,tests/expand/0132-out.jsonldtests/expand-manifest.jsonld— new sequence entry after#t0131tests/expand-manifest.html— regenerated (Haml + HtmlBeautifier;bundle exec rakewas not runnable here without libyaml-dev; same pipeline astests/Rakefile)Preview | Diff