Conversation
Author
|
I opted to name this one t0133 to avoid clashing with #686. |
Author
|
@anatoly-scherbakov It seems I need to apply to join the WG as an invited expert to be able to join and then sign what the IPR commitments thing is? |
|
anatoly-scherbakov marked as non substantive for IPR from ash-nazg. |
anatoly-scherbakov
approved these changes
Aug 4, 2026
anatoly-scherbakov
changed the base branch from
main
to
fix/fork-pr-report-generation
August 4, 2026 17:06
This adds a test to check that when the context has a default language and we're expanding a string value that has a type mapping, the default language is not added. It ensures Step 5 in Value Expansion is only performed for string values in the absence of a type mapping. Fixes: w3c#700
anatoly-scherbakov
force-pushed
the
default-lang-value-typemapping
branch
from
August 4, 2026 17:08
ed895ed to
5f57f2c
Compare
Contributor
|
@daenney thanks for contributing this!
Now we'll need both of these PRs approved by someone with write access, I added people as reviewers to both. |
Author
|
No worries at all, thanks for doing all this! |
anatoly-scherbakov
requested review from
a team,
iherman,
msporny,
pchampin and
victorjunlu
August 5, 2026 08:57
Contributor
|
@daenney I am afraid we accidentally closed this :/ PR stacks over forks do not behave as I intended. Would you be open to raise it again? I am sorry! |
Contributor
|
Or otherwise I can look into recreating it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to check that when the context has a default language and we're expanding a string value that has a type mapping, the default language is not added.
It ensures Step 5 in Value Expansion is only performed for string values in the absence of a type mapping.
Fixes: #700