Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are limited to updated integration assertions, with no unresolved issues.
Pull request overview
Updates integration assertions to accept direct CommonJS external calls emitted by modern-module output.
Changes:
- Removes reliance on
module.exportswrappers. - Uses word-boundary matching for plain
requirecalls. - Preserves existing externalization checks.
File summaries
| File | Description |
|---|---|
tests/integration/externals/index.test.ts |
Adjusts external-output assertions for modern Rspack behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SoonIter
enabled auto-merge (squash)
September 18, 2026 09:47
auto-merge was automatically disabled
September 18, 2026 09:58
Pull request was closed
Timeless0911
deleted the
codex/eco-ci-auto/externals-runtime-assertions-20260918
branch
September 18, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eco-CI source
origin/data:rspack.jsoncommitSha)module.exports = __rspack_createRequire_require(...), but modern-module output emits the external calls directly.57087f50a80fecfc706e1d296444432cce9eab3apasses in run 35215608792 and fails in the first post-merge run 35304243186. The latest surface PR #15758 only changes Rspack tests. Generated fixture configs enable modern-module; the official first-bad WASM artifact reproduces all three assertions locally.Fix
Check the external call and request without requiring the removed
module.exportswrapper. Keep the existing import, target-specific require, lazy import, remapping, and runtime assertions. Plainrequirechecks use a word boundary so they cannot accidentally match__rspack_createRequire_require. Only this test file changes; no dependencies, snapshots, or runtime code change.Validation
pnpm install --frozen-lockfileandpnpm build— passed.pnpm check— lint, type check, and formatting passed.pnpm test:integration tests/integration/externals/index.test.ts— 10 passed with the unchanged lockfile (Rsbuild 2.2.6 / Rspack 2.2.4).DEBUG=rsbuild pnpm test:integration tests/integration/externals/index.test.ts— 10 passed; generated configs confirmoutput.library.typeandexternalsTypearemodern-module.RSPACK_BINDING="$WASM_PACKAGE" NODE_OPTIONS="--import $TARGET_HOOK --max-old-space-size=6144" pnpm test:integration tests/integration/externals/index.test.ts— original assertions: 3 failed / 7 passed; patched assertions: 10 passed. The isolated harness resolves core to published 2.2.6 and loads the official WASM binary from Rspack CI run 35303892819 at475c7ad20f5dded5c1139e3bc820673c9a59f015. That commit changes no core JS or Node binding interface relative to 2.2.6. The hook and artifact stay outside the repository.