Skip to content

test: accept direct CommonJS external calls - #1931

Closed
SoonIter wants to merge 1 commit into
mainfrom
codex/eco-ci-auto/externals-runtime-assertions-20260918
Closed

SoonIter wants to merge 1 commit into
mainfrom
codex/eco-ci-auto/externals-runtime-assertions-20260918

Conversation

@SoonIter

Copy link
Copy Markdown
Member

🤖 AUTO-GENERATED by the daily-rspack-eco-ci-triage automation from an Rstack ecosystem CI failure.

Eco-CI source

Fix

Check the external call and request without requiring the removed module.exports wrapper. Keep the existing import, target-specific require, lazy import, remapping, and runtime assertions. Plain require checks use a word boundary so they cannot accidentally match __rspack_createRequire_require. Only this test file changes; no dependencies, snapshots, or runtime code change.

Validation

  • pnpm install --frozen-lockfile and pnpm build — passed.
  • pnpm check — lint, type check, and formatting passed.
  • pnpm test:integration tests/integration/externals/index.test.ts — 10 passed with the unchanged lockfile (Rsbuild 2.2.6 / Rspack 2.2.4).
  • DEBUG=rsbuild pnpm test:integration tests/integration/externals/index.test.ts — 10 passed; generated configs confirm output.library.type and externalsType are modern-module.
  • Target comparison: RSPACK_BINDING="$WASM_PACKAGE" NODE_OPTIONS="--import $TARGET_HOOK --max-old-space-size=6144" pnpm test:integration tests/integration/externals/index.test.ts — original assertions: 3 failed / 7 passed; patched assertions: 10 passed. The isolated harness resolves core to published 2.2.6 and loads the official WASM binary from Rspack CI run 35303892819 at 475c7ad20f5dded5c1139e3bc820673c9a59f015. That commit changes no core JS or Node binding interface relative to 2.2.6. The hook and artifact stay outside the repository.
  • Not run: the full ecosystem suite or the latest Linux native binding locally. The latest Linux failure and the first-bad Linux failure have the same three signatures. No local dependency overrides are committed.

Copilot AI lite review requested due to automatic review settings September 18, 2026 09:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T09:16:17.212010Z f313704 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are limited to updated integration assertions, with no unresolved issues.

Pull request overview

Updates integration assertions to accept direct CommonJS external calls emitted by modern-module output.

Changes:

  • Removes reliance on module.exports wrappers.
  • Uses word-boundary matching for plain require calls.
  • Preserves existing externalization checks.
File summaries
File Description
tests/integration/externals/index.test.ts Adjusts external-output assertions for modern Rspack behavior.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SoonIter
SoonIter enabled auto-merge (squash) September 18, 2026 09:47
auto-merge was automatically disabled September 18, 2026 09:58

Pull request was closed

@Timeless0911
Timeless0911 deleted the codex/eco-ci-auto/externals-runtime-assertions-20260918 branch September 18, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants