Skip to content

fix(release): verify R2 objects over HTTP/2 #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Teakowa merged 1 commit into from
Sep 28, 2026
Merged

fix(release): verify R2 objects over HTTP/2 #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ https://install.wrightkit.dev/wright/install.ps1

The publisher takes both files from the exact release commit, uploads them
after verifying the immutable archive/checksum set, and fetches them back over
HTTP/1.1 to compare their bytes and check their response headers. Each script
HTTP/2 to compare their bytes and check their response headers. Each script
uses `Cache-Control: no-store, max-age=0` and
`Content-Type: text/plain; charset=utf-8`. The scripts are verified before the
stable `latest/version` pointer advances. Nightly publication does not change
Expand Down
6 changes: 3 additions & 3 deletions scripts/publish-r2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ verify_public() {
local base_url="$1" key="$2" source="$3" cache_pattern="$4" content_type_pattern="$5"
local downloaded
downloaded="$GITHUB_WORKSPACE/downloaded-$(basename "$key")"
curl --http1.1 --fail --silent --show-error --location --output "$downloaded" "$base_url/$key"
curl --http2 --fail --silent --show-error --location --output "$downloaded" "$base_url/$key"
cmp --silent "$source" "$downloaded"
curl --http1.1 --fail --silent --show-error --head "$base_url/$key" | \
curl --http2 --fail --silent --show-error --head "$base_url/$key" | \
grep --ignore-case --extended-regexp "^cache-control:.*$cache_pattern" >/dev/null
curl --http1.1 --fail --silent --show-error --head "$base_url/$key" | \
curl --http2 --fail --silent --show-error --head "$base_url/$key" | \
grep --ignore-case --extended-regexp "^content-type:.*$content_type_pattern" >/dev/null
rm -f "$downloaded"
}
Expand Down
Loading