Support clip fill rules across rendering backends - #105
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry
peniko::FillthroughPaintScene::push_layerandpush_clip_layer, recording/replay, and all Skia/Vello backends so SVGclip-rule: evenoddproduces holes rather than a nonzero clip.SVG clipping now uses the parsed clip path's rule (not
fill-rule). Older serialized commands default to nonzero when the newfillfield is absent. This is a breakingPaintSceneAPI change; existing callers should passFill::NonZeroto retain their behavior.Verified with workspace tests, workspace Clippy (
-D warnings), formatting, and wasm/WebGL Clippy. Includes pixel tests for both rules, compositing layers, scene replay, and serialization compatibility.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e0ae5a7e77b4472fa049798331653054
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e0ae5a7e77b4472fa049798331653054?variant=devin-insiders
Requested by: @nicoburns