Self-host: sync mb_get_info JIT units into compile spine (7962/7962) - #35574
Merged
Conversation
MbGetInfoRuntime/JitHelper/JitMbGetInfo were on the vm.php inventory path but missing from compiler_lib_spine_smoke, breaking north-star5-verify-fast step 2. Spine footnotes and bundle test assertion updated via spine-sync. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
). PR #35574 added MbGetInfoRuntime/JitHelper/JitMbGetInfo to the compile spine but omitted the stamp refresh; ci-fast step check-selfhost-spine-sidecar-sync was red. Stamp-only follow-up, peer Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
). (#35577) PR #35574 added MbGetInfoRuntime/JitHelper/JitMbGetInfo to the compile spine but omitted the stamp refresh; ci-fast step check-selfhost-spine-sidecar-sync was red. Stamp-only follow-up, peer Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…low-up). (#35579) #35574 added JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime to the compile spine but left duplicate require_once lines (7965/7962). Remove the three extras so spine-count-sync reports 7962/7962 again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…. (#35581) Two racing spine-sync PRs left duplicate require_once for JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime — inflating the M2 counter to 7965/7962 and failing check-selfhost-spine-count-sync on ci-fast. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitMbGetInfo,MbGetInfoJitHelper, andMbGetInfoRuntimetocompiler_lib_spine_smoke/main.php— they were on the vm.php inventory path (Stdlib: mb_get_info()/mb_output_handler() missing — undefined vs Zend mbstring (ext/mbstring/mbstring.c) #20014) but missing from the literal spine bundle.BootstrapSelfhostBundleTestassertion viaspine-sync --footnotes-only.Root cause
make north-star5-verify-faststep 2 failed:check-selfhost-spine-coverage-syncreported 3 missing inventory files after mb_get_info runtime-type lowering landed without a spine sync.Verification
Not covered: gen-0 sidecar relink (
check-selfhost-spine-sidecar-syncstill stale — stamp-only debt, no blob change in this PR).Closes #78 (spine coverage increment)
Made with Cursor