Self-host: add mb_get_info JIT units to compile spine (#35570 follow-up) - #35575
Merged
Conversation
…up). Sync spine coverage for JitMbGetInfo/MbGetInfoJitHelper/MbGetInfoRuntime after Co-authored-by: Cursor <cursoragent@cursor.com> #35570 landed without spine includes; refresh 7962/7962 footnotes and gen-0 stamp.
This was referenced Aug 28, 2026
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…. (#35581) Two racing spine-sync PRs left duplicate require_once for JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime — inflating the M2 counter to 7965/7962 and failing check-selfhost-spine-count-sync on ci-fast. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitMbGetInfo.php,MbGetInfoJitHelper.php, andMbGetInfoRuntime.phptocompiler_lib_spine_smokeafter AOT: mb_get_info() runtime type via NestedJIT (#20014 leftover) #35570 landed without spine includes (ci-fast spine-sync was red: 7959/7962).Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (7962 inventory files covered)php script/check-selfhost-spine-count-sync.php→ OK (7962/7962)php script/check-selfhost-spine-sidecar-sync.php→ OK (stamp matches spine SHA-1)php script/check-wave3-roadmap-sync.php→ OK (7962/7962)make north-star5-verify-fast→ OK (spine 7962/7962, VM driver probe ok)./script/aot-smoke.sh→ 8/8 (verified earlier on master before branch)Follow-up to #35570; unblocks ci-fast spine-sync gate.
Made with Cursor