Let listing photos be picked several at a time - #118
Open
AndrewG828 wants to merge 1 commit into
Conversation
`NewListingViewModel` tracked a single `PhotosPickerItem`, so adding nine photos meant nine trips through the picker. It now holds a selection array and loads the batch in one pass, trimmed to whatever slots are left. Two bugs fall out of the rewrite: - The picker enforced a limit of 7 images while `PaginatedImageView` advertised 9, so the last two picks were silently dropped. Both now read `NewListingViewModel.maxImages`, and the system picker is given `maxSelectionCount: remainingImageSlots` so it stops you at the limit instead of discarding the overflow afterwards. - The old loader appended from a `DispatchQueue.main.async` block inside an already-`@MainActor` view model, which reordered appends against the `selectedItem = nil` reset. `removeImage(at:)` is added here for the Sell form, which lets you delete a photo from the carousel. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewListingViewModeltracked a singlePhotosPickerItem, so adding nine photosmeant nine trips through the picker. It now holds a selection array and loads
the batch in one pass, trimmed to whatever slots are left.
Two bugs fall out of the rewrite:
PaginatedImageViewadvertised9, so the last two picks were silently dropped. Both now read
NewListingViewModel.maxImages, and the system picker is givenmaxSelectionCount: remainingImageSlotsso it stops you at the limit insteadof discarding the overflow afterwards.
DispatchQueue.main.asyncblock inside analready-
@MainActorview model, which reordered appends against theselectedItem = nilreset.removeImage(at:)is added here for the Sell form, which lets you delete aphoto from the carousel.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W