Crop profile photos before upload and make availability saves explicit - #125
Open
AndrewG828 wants to merge 1 commit into
Conversation
Picking a profile photo used the raw image, so a landscape shot became a circle cropped through the middle of whatever the camera happened to centre. Photos now go through an adjust step — pinch, drag or use the slider inside the circular mask — and the crop is applied to pixels before upload rather than only to how the image is displayed. Pan and zoom are clamped to the image bounds so you can't drag empty space into frame. Availability's Save button moves into the toolbar and only enables when the grid differs from what was saved, which needed the view to track the saved selection rather than only the current one. Previously the button was inline, always enabled, and gave no acknowledgement — you couldn't tell a successful save from a no-op. A confirmation alert closes that loop. Cropping reuses `UIImage.flattenedOrientation()` instead of carrying its own copy of the EXIF-flattening routine. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking a profile photo used the raw image, so a landscape shot became a
circle cropped through the middle of whatever the camera happened to centre.
Photos now go through an adjust step — pinch, drag or use the slider inside the
circular mask — and the crop is applied to pixels before upload rather than only
to how the image is displayed. Pan and zoom are clamped to the image bounds so
you can't drag empty space into frame.
Availability's Save button moves into the toolbar and only enables when the grid
differs from what was saved, which needed the view to track the saved selection
rather than only the current one. Previously the button was inline, always
enabled, and gave no acknowledgement — you couldn't tell a successful save from
a no-op. A confirmation alert closes that loop.
Cropping reuses
UIImage.flattenedOrientation()instead of carrying its owncopy of the EXIF-flattening routine.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W