Replace the Home header with a floating search toolbar - #121
Open
AndrewG828 wants to merge 1 commit into
Conversation
Home's static header (wordmark, search icon, bell) becomes a glass toolbar that floats over the feed: a search pill that expands into the full search card, a notification button, and the section's filter button once that scrolls out of view. Search now happens in place instead of pushing `SearchView`. Results render into the same scroll view as the feed, so there is no navigation transition between typing and reading results. The Shop By Category row moves to Explore, which is where browsing by category now lives, and the expandable add button goes with the Sell tab. What is left on Home is the recent-listings feed and its filter. Two things to look at: - Scrolling is disabled only while the search card covers the feed with no results yet. Tying it to "is the card open" — the obvious version — also freezes the results the card produces, so you can't scroll past the first row. - Toolbar filter visibility is driven by KVO on the enclosing `UIScrollView`'s content offset. SwiftUI's PreferenceKey and GeometryReader paths stall mid-scroll and leave the button stuck in whichever state it was in. `onScrollGeometryChange` would do the same job natively, but only from iOS 18 and the deployment target is 17.5, so this is one mechanism instead of two. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home's static header (wordmark, search icon, bell) becomes a glass toolbar that
floats over the feed: a search pill that expands into the full search card, a
notification button, and the section's filter button once that scrolls out of
view.
Search now happens in place instead of pushing
SearchView. Results render intothe same scroll view as the feed, so there is no navigation transition between
typing and reading results.
The Shop By Category row moves to Explore, which is where browsing by category
now lives, and the expandable add button goes with the Sell tab. What is left
on Home is the recent-listings feed and its filter.
Two things to look at:
results yet. Tying it to "is the card open" — the obvious version — also
freezes the results the card produces, so you can't scroll past the first row.
UIScrollView'scontent offset. SwiftUI's PreferenceKey and GeometryReader paths stall
mid-scroll and leave the button stuck in whichever state it was in.
onScrollGeometryChangewould do the same job natively, but only from iOS 18and the deployment target is 17.5, so this is one mechanism instead of two.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017R8mua9xepzF3mnRETtd6W