fix(alerts): Remove deprecated transactions dataset - #1516
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Jared, take over the PR address all review discussions and then get it merged |
The transactions dataset was removed from alerts. Rather than hard-fail requests that still pass --dataset transaction(s), route them to the spans dataset and add is_transaction:true to the query so existing use cases keep working. Print a gentle tip nudging users toward --dataset spans directly. Also add a span -> spans alias for smoother transition.
|
took over per @BYK's request. addressed the dataset discussion in f3b8e0b: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e63cd9. Configure here.
Remove calls to the deprecated/unsupported `transactions` dataset from the `explore` surface area. Following the lead of #1516, you can still ask to explore `transaction(s)` and we'll route you to `spans` with `is_transaction:true` to smooth out the transition for users. Fixes BROWSE-682.
This branch was successfully deployed
2 participants
transactionsis no longer a valid dataset for alerts (the same use cases are supported by spans). All existing alerts have been migrated off of those datasets and creating new alerts that use them has been blocked on all billing plans.Remove all references to transactions datasets from alerts code and skills.
See BROWSE-682.